Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently went to a bunch of effort splitting code across header files only to discover that I'd actually done it a couple of years ago in 747dd95. Retaining the more recent version.
n_choose_k()
to new filecore/math/binomial.h
as was done previously in 64759f6(currently processing a cohort that should serve well for this purpose)
Consider initially updating them to explicitly use the "nearest" algorithm, which duplicates prior behaviour; changing the advised algorithm can be discussed in Documentation: Revisit FBA instructions #2685
.h
to.cpp
and explicitly instantiate the two required versions.mif
to.npy
vector<index_type>
is used. While this could be used during the optimisation process itself if necessary / beneficial, better would be something more consistent with the on-disk storage: an index array with count & offset per fixel, which provides lookup into a table of fixel indices. An accessor class could deal with translation of such, providing iteration via:
operator, etc..all2all
" class (or just remove it)