New fixelcorrespondence #2688
Draft
New fixelcorrespondence #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmand Previous fixelcorrespondence command served a dual purpose: it would both determine the appropriate subject fixel to use in projecting data to a given template fixel, and then perform that projection to produce subject data for the template fixel dataset. This changeset breaks this process into two separate steps. The fixelcorrespondence command now produces as its output a dataset that represents the correspondence mapping between subject and template fixels. New command fixel2fixel is then responsible for utilising that pre-determined mapping to project data from subject fixels to template fixels. The separation of these stages permits the exploration of alternative strategies for establishing the correspondence between subject and template fixles, inclusing accounting for cases where that correspondence is not a trivial one-to-one mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently went to a bunch of effort splitting code across header files only to discover that I'd actually done it a couple of years ago in 747dd95. Retaining the more recent version.
n_choose_k()to new filecore/math/binomial.has was done previously in 64759f6(currently processing a cohort that should serve well for this purpose)
Consider initially updating them to explicitly use the "nearest" algorithm, which duplicates prior behaviour; changing the advised algorithm can be discussed in Documentation: Revisit FBA instructions #2685
.hto.cppand explicitly instantiate the two required versions.mifto.npyvector<index_type>is used. While this could be used during the optimisation process itself if necessary / beneficial, better would be something more consistent with the on-disk storage: an index array with count & offset per fixel, which provides lookup into a table of fixel indices. An accessor class could deal with translation of such, providing iteration via:operator, etc..all2all" class (or just remove it)