Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Train diagnostic figure update #208

Merged
merged 22 commits into from
Nov 30, 2023
Merged

Train diagnostic figure update #208

merged 22 commits into from
Nov 30, 2023

Conversation

jeffjennings
Copy link
Contributor

@jeffjennings jeffjennings commented Nov 29, 2023

NOTE: This PR should only be reviewed after #207 and #206 are merged into main and main merged into this branch (it was branched from 207, which was branched from 206)

  • Adds some new plots to the diagnostic figure that's generated at some chosen interval during a training loop:
    • difference image between model image at current iteration and that at the previous instance of the interval
    • flux of model image vs iteration
    • learning rate vs iteration
  • Tracks model flux and learning rate in training loop
  • Some general cleanup in the training and cross-val classes

@jeffjennings
Copy link
Contributor Author

jeffjennings commented Nov 29, 2023

Example of the new train_diagnostics_fig (convergence was reached at shown epoch)
entropy1e-05_TSV0 0001__train_diag_kfold0_epoch02623

@jeffjennings jeffjennings requested a review from iancze November 29, 2023 07:56
Copy link
Collaborator

@iancze iancze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Would also be good to roll into a tutorial or other narrative documentation.

@jeffjennings
Copy link
Contributor Author

Thanks! I've made a note about adding this in #63; there might be a good earlier place in the docs to put it, but #63 is looking like the hub for the next tutorial additions to the docs.

@jeffjennings jeffjennings merged commit 306eb24 into main Nov 30, 2023
4 checks passed
@jeffjennings jeffjennings deleted the train_diag_fig_update branch November 30, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants