Documenting Briggs residual visualization and removing GriddedResidualConnector #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffjennings
approved these changes
Feb 20, 2023
Co-authored-by: Jeff Jennings <[email protected]>
|
@jeffjennings thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When complete, this will close #157 and #110. Then, this should enable #156 to be completed and merged.
This pull request removes the
connectors.pyfile and theGriddedResidualConnector. It shiftsindex_vistodatasets.py. It removes (or comments out)GriddedResidualConnectorfrom the few places it appears in the codebase. In some places (like the optimization tutorial), we provided instructions on how to use the NuFFT layer and dirty image capabilities to produce residual images.