Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GriddedResidualConnector from the codebase #157

Closed
iancze opened this issue Feb 19, 2023 · 0 comments · Fixed by #158
Closed

Remove GriddedResidualConnector from the codebase #157

iancze opened this issue Feb 19, 2023 · 0 comments · Fixed by #158

Comments

@iancze
Copy link
Collaborator

iancze commented Feb 19, 2023

As described in #154 and related issues in #126 , #110 and #100, the GriddedResidualConnector class will be largely redundant once the Briggs weighting residual imaging process (#110) is fully integrated into the codebase.

We should remove GriddedResidualConnector from the codebase entirely and update all code that uses it to follow the Briggs/NuFFT residual imaging process. Once this is done, the only remaining routine in connectors.py will be index_vis, which should probably be moved to datasets.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant