Skip to content

Commit

Permalink
#40 Removed Restarting the driver & Added Implicit Wait again
Browse files Browse the repository at this point in the history
-> Restarting the webdriver (firefox) before each data driven test leads
to Jenkins crashing (Reason unknown)
- (Temporarily) Removed Restarting the drive before each data driven
test
- (Temporarily) Added Implicit Wait again
  • Loading branch information
helkv committed Mar 11, 2019
1 parent f1a7c88 commit e73cab7
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 4 deletions.
2 changes: 2 additions & 0 deletions src/test/base/SeleniumTestSuite.java
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ private static void setDriver(String browserType) {
log4j.info("Window maximised.");

driver.manage().timeouts().pageLoadTimeout(10, TimeUnit.SECONDS);
//TODO: Remove implicitlyWait again, as soon as Bugs Firefox/Jenkins crashing are fixed
driver.manage().timeouts().implicitlyWait(10, TimeUnit.SECONDS);
}

private static WebDriver initFirefoxDriver() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,9 @@ public CreateDefaultStatementPrivate(String type, String statementName, String i

@BeforeClass
public void resetDriver() {
//FIXME: Restarting the bowser leads to a crash on Jenkins
// Restart the browser to prevent Firefox from crashing (see Ticket #40 'Firefox memory leak')
restartDriver();
// restartDriver();
}

/**
Expand Down
3 changes: 2 additions & 1 deletion src/test/scripts/statements/CreateDefaultStatementTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,9 @@ public CreateDefaultStatementTest(String type, String statementName, String isPr

@BeforeClass
public void resetDriver() {
//FIXME: Restarting the bowser leads to a crash in Jenkins
// Restart the browser to prevent Firefox from crashing (see Ticket #40 'Firefox memory leak')
restartDriver();
// restartDriver();
}

/**
Expand Down
3 changes: 2 additions & 1 deletion src/test/scripts/statements/CreateNewStatementPrivate.java
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,9 @@ public CreateNewStatementPrivate(String type, String statementName, String isPre

@BeforeClass
public void resetDriver() {
//FIXME: Restarting the bowser leads to a crash on Jenkins
// Restart the browser to prevent Firefox from crashing (see Ticket #40 'Firefox memory leak')
restartDriver();
// restartDriver();
}

/**
Expand Down
3 changes: 2 additions & 1 deletion src/test/scripts/statements/CreateNewStatementTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,9 @@ public CreateNewStatementTest(String type, String statementName, String isPredef

@BeforeClass
public void resetDriver() {
//FIXME: Restarting the bowser leads to a crash on Jenkins
// Restart the browser to prevent Firefox from crashing (see Ticket #40 'Firefox memory leak')
restartDriver();
// restartDriver();
}

@Test(priority = 1)
Expand Down

0 comments on commit e73cab7

Please sign in to comment.