Skip to content

CI updates and cleanup #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025
Merged

CI updates and cleanup #891

merged 3 commits into from
Feb 4, 2025

Conversation

altheaden
Copy link
Collaborator

This PR adds a few CI updates we've implemented in other repos recently:

  1. I updated the default python version in various places to 3.13, and changed this version from a magic number to a variable in a few places (for consistency).
  2. I enabled auto-update-conda which we had disabled previously thinking it was causing trouble, but it wasn't.
  3. I removed the caching step for creating a conda environment - it doesn't appear to be saving any time and we don't consider it worth keeping.

Checklist

  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@altheaden
Copy link
Collaborator Author

Testing

I pushed this to my main branch on my fork and ran all the CI tests, everything passed and the docs built as expected (as far as I can tell).

@xylar I updated 3.10 -> 3.13 in a few places besides the docs, so let me know if that looks OK to you.

@altheaden altheaden requested a review from xylar February 4, 2025 20:32
@altheaden
Copy link
Collaborator Author

@xylar I don't have permission to re-run jobs but I think the failed job is due to the CI issues we've been experiencing lately.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@xylar xylar merged commit 88d25f7 into MPAS-Dev:main Feb 4, 2025
6 checks passed
@xylar xylar deleted the update-ci branch February 4, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants