Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated importlib.resources.path() call #493

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jan 10, 2023

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar self-assigned this Jan 10, 2023
@xylar xylar added the dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script label Jan 10, 2023
@xylar xylar force-pushed the fix_importlib_resource_path_in_conda branch from 49bf814 to 045418b Compare January 10, 2023 14:04
@xylar
Copy link
Collaborator Author

xylar commented Jan 10, 2023

Testing

I was able to create a development conda environment on Chicoma using a test merge of this branch together with #492 and #494. While the spack environment is still building, the part of the bootstrap code that is affected by this change has already run successfully and showed no deprecation warnings related to importlib.resources.

@xylar xylar merged commit d33dae4 into MPAS-Dev:main Jan 10, 2023
@xylar xylar deleted the fix_importlib_resource_path_in_conda branch January 10, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant