Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix barotropic streamfuncion #1050

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix barotropic streamfuncion #1050

merged 1 commit into from
Jan 17, 2025

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jan 17, 2025

Without this fix, we were seeing:

  File "/gpfs/fs1/home/ac.xylar/mpas_work/MPAS-Analysis/add_OSNAP_TSclimtransects/mpas_analysis/shared/plot/climatology_map.py", line 615, in plot_panel
    for collection in cs.collections:
                      ^^^^^^^^^^^^^^
AttributeError: 'GeoContourSet' object has no attribute 'collections'

in the logs for barotropic streamfuncion plot tasks.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar added the bug label Jan 17, 2025
@xylar xylar self-assigned this Jan 17, 2025
@xylar
Copy link
Collaborator Author

xylar commented Jan 17, 2025

Testing

I ran the test suite on Chrysalis. I didn't check all test results but the main test passes, whereas it was crashing with the error message above before. BSF plots look like normal:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/fix-bsf-plots/main_py3.11/ocean/barotropicStreamfunction_antarctic_extended_main_py3.11_ANN_years0003-0010.png

image

@xylar xylar merged commit 5831d88 into MPAS-Dev:develop Jan 17, 2025
5 checks passed
@xylar xylar deleted the fix-bsf-plots branch January 17, 2025 20:58
@xylar xylar mentioned this pull request Jan 17, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant