fix: remove non-ros dependency

[incebellipipo]

Solves #5

It is not ready for merge yet; we can discuss the ways to handle SDK dependency before it.

[incebellipipo]

What about adding

include(FetchContent)
if (NOT TARGET qualisys_cpp_sdk)
  message(STATUS "${PROJECT_NAME}: `qualisys_cpp_sdk` targets not found. Attempting to fetch contents...")
  FetchContent_Declare(
    qualisys_cpp_sdk
    GIT_REPOSITORY https://github.com/qualisys/qualisys_cpp_sdk
    GIT_TAG        master
  )
  FetchContent_MakeAvailable(qualisys_cpp_sdk)
else()
  message(STATUS "qualisys_cpp_sdk: `qualisys_cpp_sdk` targets found.")
endif()

to the cmakelists.txt ?

[incebellipipo]

This works like that. Commit messages got a little messy though. If you find this approach good enough, I can clean up the commit messages and make another PR, or somehow update this one.

[fmrico]

Hi @incebellipipo

LGTM, go ahead. Is the PR ready to merge?

Thanks!!

[incebellipipo]

Nööö!!! 😆

There are too many weird commits in it. I will properly do it and create another pull request. I will turn this into a draft for now.

[fmrico]

Hi @incebellipipo

Did you progress with this?

[aaggj]

Hi @incebellipipo,
Any updates?

[incebellipipo]

This should ideally be a fork and it should be something like: mocap4ros2/qualisys_cpp_sdk
@fmrico

[incebellipipo]

There are some updates! Yes, but I didn't get any notifications about your messages. Sorry for the late update.

There is an issue with the qualisys_sdk package right now. I sent a PR to them. Once they approve of it, I will push the code. See qualisys/qualisys_cpp_sdk#110

FYI, @fmrico I suggest forking https://github.com/qualisys/qualisys_cpp_sdk . They have made some breaking changes, and it messed with my automated process. It might have been good to not have this PR accepted before. See my comment above.

This is ready to be merged I believe.

[fmrico]

Hi @incebellipipo

I am merging this, as you said it was ready.

Are you suggesting forking https://github.com/qualisys/qualisys_cpp_sdk into the MOCAP4ROS2 organization? Maybe we are at risk of diverging from the official SDK...

[incebellipipo]

Yes, I am in fact suggesting forking the official qualisys_cpp_sdk in mocap4ros2 organization. It is a way to ensure having a working "copy" of the software.

This problem caught my attention only when my automated builds started to fail. Then I found out that qualisys_cpp_sdk package was going through some refactoring. But I seriously was not expecting them to do that refactoring on the "master" branch. And they are not testing the software for linux.

I believe, once they are done with this refactoring, that SDK repository should be forked into mocap4ros2 organization, and that fork should peridically (maybe every 6 months or so should suffice) be synchronized. On another note, I would personally thrust the URL https://github.com/mocap4ros2-project more than https://github.com/incebellipipo 😂
see:

mocap4ros2_qualisys/qualisys_driver/CMakeLists.txt

Line 30 in 93b05f3

GIT_REPOSITORY https://github.com/incebellipipo/qualisys_cpp_sdk

According to the recent discussions, they will soon be done with the refactoring process.

You can read more about it here qualisys/qualisys_cpp_sdk#112