Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add Smartspacer support #922

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WIP: add Smartspacer support #922

wants to merge 2 commits into from

Conversation

pacjo
Copy link

@pacjo pacjo commented Jul 4, 2024

when ready, will close #771 .

So, a few things. While there is basic support here, it's not ready for merging, hence the draft. Also there won't be any new commits from me for probably 2 or 3 weeks, since it's summer and I'm not taking my pc with me. If someone wants to pick this up during that time, it'd awesome.

...and there are still some issues to iron out, so a TODO:

  • fix touch input, since currently dragging pages requires a two-finger swipe
  • add proper icon in widget picker
  • make background toggle-able
  • resuse smartspacer sessions / view (just don't get a new one each time)
  • don't hardcode widget size
  • (probably) correct padding all around
  • (probably) fix strings.xml, since it's the first time I'm working with translations on android
  • also add an option to disable page limit, as support was added just the other day

@pacjo pacjo marked this pull request as draft July 4, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intergrate smartspacer
1 participant