SearchVM, SearchService: improve search UX by reducing flickering
#1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are no new search results from SearchableRepositories
Sir-Photch
commented
Oct 26, 2024
Comment on lines
262
to
266
| searchActionResults.clear() | ||
| mergeStateLists(appResults, apps) | ||
| mergeStateLists(workAppResults, workApps) | ||
| mergeStateLists(privateSpaceAppResults, privateApps) | ||
| mergeStateLists(hiddenResults, hiddenItems) |
There was a problem hiding this comment.
Maybe it makes sense to set previousResults here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #617 and improves search UX by not redrawing search results until there are actual results by any
SearchableRepository. This "fixes" the "flickering" that would otherwise occur when searching:kvaesitso-noflicker.mp4
I also went and replaced
MutableStateOf({Int,Float})to the respectiveMutable{Int,Float}StateOfthat I found on the way, for good measure.Now, I haven't tested this much, so I'm not sure whether or not this introduces any regressions. But I think the result of an UI that does not flicker when typing is quite promising. Let me know what you think.
And sorry for that messed up commit-history. 😅