This repository has been archived by the owner on Jun 23, 2021. It is now read-only.
Sync sys darkmode #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When entering the site for the first time (the dark mode has never been set using the toggle button), it automatically detects the device's appearance mode (light or dark) and applies it to the site, it'll ignore the device mode if the user has already visited the site.
How Has This Been Tested?
This has been tested on 2 devices Macbook/iPhone with Safari/Chrome, the code(device's mode detector) is supported on all browsers.
Mentions
@wrussell1999 @ShrillShrestha
Types of changes
Checklist