-
Notifications
You must be signed in to change notification settings - Fork 121
fixed minor accessibility issues #69
base: main
Are you sure you want to change the base?
Conversation
_includes/navbar.html
Outdated
@@ -3,7 +3,7 @@ | |||
<a href="{{ '/' | relative_url }}"> | |||
<div class="nav-logo"> | |||
<img src="./assets/img/logo.svg" /> | |||
<a class="nav-link" href="{{ site.url }}/cv/resume.pdf">Resume</a> | |||
<a class="nav-link" href="{{ site.url }}/cv/resume.pdf" title="Download Resume as PDF">Resume</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This where the problem is coming from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small fix I'd like to see that isn't your fault, but will need to be fixed here since you're editing the line already:
{{ site.url }}
isn't the right way to make absolute URLs in Jekyll. It works some of the time but can break. The proper way is to use {{ '/cv/resume.pdf' | absolute_url }}
, which will work in all cases.
Co-authored-by: James Martindale <[email protected]>
Co-authored-by: James Martindale <[email protected]>
Thanks for the updates |
@Korusuke, please review it. Thanks |
Changes
The changes are made to fix issue #62
The website had minor accessibility issues like:
How Has This Been Tested?
The proposed changes were tested on the local computer, and a performance was checked using chrome lighthouse
Mentions
@Korusuke, kindly review the changes
Types of changes
Checklist