Skip to content
This repository has been archived by the owner on Jun 23, 2021. It is now read-only.

Variables #51

Merged
merged 6 commits into from
Feb 3, 2021
Merged

Variables #51

merged 6 commits into from
Feb 3, 2021

Conversation

atreyamaj
Copy link
Contributor

@atreyamaj atreyamaj commented Feb 2, 2021

Changes

Put variables for:

  1. Number of cards
  2. Background
  3. Text Colour
  4. Link Colour
  5. Title Colour
  6. Body Background
  7. Card Font Size

How Has This Been Tested?

We ran it on our local machines and tracked the changes in real-time, and confirmed the enhancements.

Mentions

  1. Atreya Majumdar
  2. Lucas Lobo
  3. Alex Wilkes

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Checklist

  • Coding style of this project is followed
  • Change in documentation is required
  • Documentation has been updated accordingly
  • Unit tests have been added to cover code change

@wrussell1999 wrussell1999 self-requested a review February 3, 2021 01:12
Copy link
Member

@wrussell1999 wrussell1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks and works great!

Could you add a section to the README explaining to someone new what each variable is (what it does etc) and a brief on how they can edit these to make the site their own?

@atreyamaj
Copy link
Contributor Author

Definitely! We're on it!

@atreyamaj
Copy link
Contributor Author

@wrussell1999 We have added some documentation to the readme. Please do let us know if you can see them and if there are any further changes to be made!

@Korusuke
Copy link
Member

Korusuke commented Feb 3, 2021

Thanks for this amazing PR! Everything looks solid to me!
This is definitely going to help folks working on #53 and #55

@Korusuke Korusuke merged commit 4eb5aec into MLH-Fellowship:master Feb 3, 2021
@atreyamaj
Copy link
Contributor Author

Thanks! We had a lot of fun working on it as well :)

@atreyamaj atreyamaj deleted the variables branch February 3, 2021 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants