-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inference data loader #81
Open
EthanMarx
wants to merge
53
commits into
ML4GW:dev
Choose a base branch
from
EthanMarx:inference-data-loader
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* consolidate phenomp and phenomd apis * use chirp mass for initializing tensor size * fix ordering of parameters in tests
* add precessing spin conversion * add conversion file * restructure waveforms module * update tests * add back generator * add more robust fref check
* bug fix for xy spins * run pre-commit * pass fRD and fDM through to phenom_d phase and amp functions * switch to relative imports * use chirp mass to mass ratio conversion function * create tests for phenom_p * lower tolerance for phenom_p * comments and additional checks for fRD and fDM
* fix issue with device in phenom pv2
* Added citation and license * Updated readme * Fixed pre-commit * Add test coverage workflow * Updated gwpy and added coverage * Added coverage to workflow * Add coverage to tox installs * Correct command * Put relative_files config in correct table * Retry coverage table * Include toml extra for coverage * Include extra in tox table * Do extra correctly(?) * Add permissions to workflow * Move coverage.yaml to correct location * Make test coverage global * Fix typo * Testing * Pass coverage file env var * Fix typo * Remove debugging lines * Add .coveragerc file * Added source specification * Change how source is specified * Test with directory * Remove debugging * Add coverage badge
Add lowpass option to whitening
Add demo notebook
* add option for specifying fnames per batch * add tests for fname limit * add check for fnames > files_per_batch * add remove print statement hook * fix tests by increasing files sampled
…4GW#189) * rough high/low pass filter implementation * rename import * internalize functions * move filter to transforms and add docstrings * move to filters.py * create torch module * add tests * switch to scipy for filter coeff generation * use union type for p3.9 compatibility * add support for other filters * hardcode output since torchaudio takes (b, a) as input * export constants to be accessed as ml4gw.constants * add phenom tests * fix unassigned variable bug * fix tolerance on phenom test for filters * link scipy function * tests for other filters (cheby1, cheby2, ellip, bessel) * increase tolerance for phenom tests * update Return documentation
* improve generator to use better waveform conditioning * finalize waveform generator * add conversion function to parameter sampler * proper indexing when slicing * add proper device handling * add kwargs to phenomD and taylorf2 to soak up unused parameters * update testing * match conditioning with gwsignal * add fft into generator * add tests for waveform generator * fix pre-commit * remove coefficients tests since there is not lalsuite equivalent * update number of samples in conftest * adjust tests for off by one error * add iirfilter for highpassing * remove notebook * use relative imoprts * fix type hint * bump test tolerances * clean up tests and account for discrepancy in argma * reduce number of samples to 1000 * increas tolerance * remove unused high_pass_time_series
Set random seed for unit tests
* fix flaky powerlaw test by removing initial guess * add pytest-repeat to dev deps * bump probability with which we want errors to not fall within tolerance * allow just 1 sample to mismatch * add TODO marker * add num bad option to comapre with numpy * make filters a fixture * add low_cutoff fixture * cleanup iirfilter tests into fixtures
…correct device (ML4GW#199) * fix device issue in waveform generator * update version to 0.7.1
Add lowpass option for SNR calculation
Increment version
Moved scipy out of dev dependencies
Migrate to `uv` and `ruff`
f441cad
to
05d4736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simple inference dataloader that yields
stride_size
batches sequentially from a single file.Was seeing ~12,000 seconds / second throughput from the following simple profiling code: