Skip to content

Commit

Permalink
Increment version to v0.6.3 (#184)
Browse files Browse the repository at this point in the history
* Increment version to `v0.6.3`

* Deprecate python 3.8

* Remove py38 from tox

* Remove python 3.8 from tox tests

* resync lock file

* fix full distance prior in tests

* bump close distance max to 400

* fix comment
  • Loading branch information
EthanMarx authored Jan 11, 2025
1 parent b96f95b commit cd372f1
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 51 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
python-version: ['3.9', '3.10', '3.11', '3.12']
steps:
- uses: actions/checkout@v2

Expand Down
44 changes: 4 additions & 40 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
[tool.poetry]
name = "ml4gw"
version = "0.6.2"
version = "0.6.3"
description = "Tools for training torch models on gravitational wave data"
readme = "README.md"
authors = [
"Alec Gunny <[email protected]>", "Ethan Marx <[email protected]>", "Will Benoit <[email protected]>", "Deep Chatterjee <[email protected]"
]

[tool.poetry.dependencies]
python = "^3.8,<3.13"
python = "^3.9,<3.13"

jaxtyping = "^0.2"

Expand Down Expand Up @@ -59,18 +59,17 @@ include_trailing_comma = true
[tool.tox]
legacy_tox_ini = """
[tox]
envlist = py{38,39,310,311,312}
envlist = py{39,310,311,312}
isolated_build = true
[gh-actions]
python =
3.8: py38
3.9: py39
3.10: py310
3.11: py311
3.12: py312
[testenv:py{38,39,310,311,312}]
[testenv:py{39,310,311,312}]
deps =
pytest>=7,<8
lalsuite>=7,<8
Expand Down
10 changes: 5 additions & 5 deletions tests/waveforms/cbc/test_cbc_waveforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,19 +72,19 @@ def phi_jl(request):

@pytest.fixture()
def distance(request):
dist = Uniform(100, 300)
dist = Uniform(100, 3000)
return dist.sample((N_SAMPLES,))


@pytest.fixture()
def distance_far(request):
dist = Uniform(300, 3000)
dist = Uniform(400, 3000)
return dist.sample((N_SAMPLES,))


@pytest.fixture()
def distance_close(request):
dist = Uniform(100, 300)
dist = Uniform(100, 400)
return dist.sample((N_SAMPLES,))


Expand Down Expand Up @@ -386,7 +386,7 @@ def test_phenom_p(
# compare each waveform with lalsimulation
for i in range(len(chirp_mass)):

# test far (> 300 Mpc) waveforms (O(1e-3) agreement)
# test far (> 400 Mpc) waveforms (O(1e-3) agreement)

# construct lalinference params
params = dict(
Expand Down Expand Up @@ -465,7 +465,7 @@ def test_phenom_p(
1e21 * hc_lal_data.imag, 1e21 * hc_ml4gw.imag.numpy(), atol=1e-3
)

# test close (< 300 Mpc) waveforms (O(1e-2) agreement)
# test close (< 400 Mpc) waveforms (O(1e-2) agreement)
params["distance"] = (distance_close[i].item() * u.Mpc).to("m").value
hp_lal, hc_lal = lalsimulation.SimInspiralChooseFDWaveform(**params)

Expand Down

0 comments on commit cd372f1

Please sign in to comment.