Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing infra #163

Merged
merged 55 commits into from
May 26, 2024
Merged

Testing infra #163

merged 55 commits into from
May 26, 2024

Conversation

EthanMarx
Copy link
Contributor

@EthanMarx EthanMarx commented May 25, 2024

Adds back in github workflows to run tests! There are two separate workflows to run the libs and projects tests.

  1. Libraries are simply installed with poetry and tests run with poetry run pytest
  2. Project tests are run inside project containers after the apptainer image has been built, but before it has been converted to a docker container and uploaded to the remote repository. I've configured the docker push portion of the workflow to only trigger on pushes to main, so that it is not run on pull requests.

I've added back in some tests from the old aframe that were simple to re configure here, namely the export tests. For the rest of the projects I've added dummy tests to get the workflows running. Now that we have this, I think we'll have more motivation to start writing tests. We can slowly add them back in

@EthanMarx EthanMarx requested a review from wbenoit26 May 26, 2024 20:51
Copy link
Contributor

@wbenoit26 wbenoit26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is awesome. Will be good to have tests going again

@EthanMarx EthanMarx merged commit 5f31a18 into ML4GW:main May 26, 2024
9 checks passed
@EthanMarx EthanMarx deleted the test-infra branch May 26, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants