Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new versions clearer in the submission system #2282 #2310

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

rafgia
Copy link
Contributor

@rafgia rafgia commented Oct 2, 2024

On the Project Submission Info page, when there is a new version of a published project, a message is displayed alongside the version number stating, 'This is an update of the latest published version'. Otherwise, a message stating 'No latest version available' is displayed. #2282 closed.

@tompollard
Copy link
Member

tompollard commented Oct 2, 2024

Thanks @rafgia, this is an improvement. Please could you make a couple of minor changes?

  1. Remove the blue highlighting from the following line (which could be confused with the style used for hyperlinks) and change the text to read: "(this is an update to a published project)"
  2. So that we follow the existing structure of the document, please could change: No latest version available. to:
    Latest Published Version: No published version available.

Version: {{ project.version }}
{% if project.is_new_version %}<br>Latest Published Version: <a href="{% url 'published_project' latest_version.slug latest_version.version %}" target="_blank">{{ latest_version.version }}</a>{% endif %}
Version: {{ project.version }} {% if project.is_new_version %}<em>(this is an update to a published project)</em>{% endif %}
{% if project.is_new_version %}<br>Latest Published Version: <a href="{% url 'published_project' latest_version.slug latest_version.version %}" target="_blank">{{ latest_version.version }}</a> {% else %} <br>Latest Published Version: No published version available. {% endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest Published Version: can be moved out of the if clause:

Version: {{ project.version }} {% if project.is_new_version %}<em>(this is an update to a published project)</em>{% endif %}<br>
Latest Published Version: {% if project.is_new_version %}<a href="{% url 'published_project' latest_version.slug latest_version.version %}" target="_blank">{{ latest_version.version }}</a>{% else %} No published version available.{% endif %}

@tompollard
Copy link
Member

It looks like there is a line break missing somewhere:

Screenshot 2024-10-03 at 9 45 58 AM

@rafgia
Copy link
Contributor Author

rafgia commented Oct 3, 2024

I'm sorry, I forgot to add a break line. Now, it should be correct.

@tompollard
Copy link
Member

Thanks @rafgia, looks good. Would you like to squash your commits before we merge?

@tompollard
Copy link
Member

tompollard commented Oct 3, 2024

Small thing, but I'm pretty sure that "#2282 closed" in your commit message will not close the issue (if that's what you are going for?). According to https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests, the issue number needs to follow the keyword (e.g. you could do closes #2282)

… published project, a message is displayed alongside the version number stating, 'This is an update of the latest published version. Otherwise, a message stating 'No latest version available' is displayed. #2282 closed.

On the Project Submission Info page, when there is a new version of a published project, a message is displayed alongside the version number stating, '(this is an update to a published project)'. Otherwise, a message stating 'Latest Published Version: No published version available.' is displayed. #2282 closed.

On the Project Submission Info page, when there is a new version of a published project, a message is displayed alongside the version number stating, '(this is an update to a published project)'. Otherwise, a message stating 'Latest Published Version: No published version available.' is displayed. #2282 closed.

On the Project Submission Info page, when there is a new version of a published project, a message is displayed alongside the version number stating, '(this is an update to a published project)'. Otherwise, a message stating 'Latest Published Version: No published version available.' is displayed. #2282 closed.
@tompollard tompollard merged commit 5e6b76c into dev Oct 3, 2024
8 checks passed
@tompollard
Copy link
Member

Thanks!

@tompollard tompollard deleted the rg/fix2282 branch October 3, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants