-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make new versions clearer in the submission system #2282 #2310
Conversation
Thanks @rafgia, this is an improvement. Please could you make a couple of minor changes?
|
Version: {{ project.version }} | ||
{% if project.is_new_version %}<br>Latest Published Version: <a href="{% url 'published_project' latest_version.slug latest_version.version %}" target="_blank">{{ latest_version.version }}</a>{% endif %} | ||
Version: {{ project.version }} {% if project.is_new_version %}<em>(this is an update to a published project)</em>{% endif %} | ||
{% if project.is_new_version %}<br>Latest Published Version: <a href="{% url 'published_project' latest_version.slug latest_version.version %}" target="_blank">{{ latest_version.version }}</a> {% else %} <br>Latest Published Version: No published version available. {% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest Published Version:
can be moved out of the if clause:
Version: {{ project.version }} {% if project.is_new_version %}<em>(this is an update to a published project)</em>{% endif %}<br>
Latest Published Version: {% if project.is_new_version %}<a href="{% url 'published_project' latest_version.slug latest_version.version %}" target="_blank">{{ latest_version.version }}</a>{% else %} No published version available.{% endif %}
I'm sorry, I forgot to add a break line. Now, it should be correct. |
Thanks @rafgia, looks good. Would you like to squash your commits before we merge? |
Small thing, but I'm pretty sure that |
… published project, a message is displayed alongside the version number stating, 'This is an update of the latest published version. Otherwise, a message stating 'No latest version available' is displayed. #2282 closed. On the Project Submission Info page, when there is a new version of a published project, a message is displayed alongside the version number stating, '(this is an update to a published project)'. Otherwise, a message stating 'Latest Published Version: No published version available.' is displayed. #2282 closed. On the Project Submission Info page, when there is a new version of a published project, a message is displayed alongside the version number stating, '(this is an update to a published project)'. Otherwise, a message stating 'Latest Published Version: No published version available.' is displayed. #2282 closed. On the Project Submission Info page, when there is a new version of a published project, a message is displayed alongside the version number stating, '(this is an update to a published project)'. Otherwise, a message stating 'Latest Published Version: No published version available.' is displayed. #2282 closed.
Thanks! |
On the Project Submission Info page, when there is a new version of a published project, a message is displayed alongside the version number stating, 'This is an update of the latest published version'. Otherwise, a message stating 'No latest version available' is displayed. #2282 closed.