Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix z statistic computation in computefeats2 #644

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

[FIX] Fix z statistic computation in computefeats2 #644

wants to merge 26 commits into from

Commits on Nov 25, 2019

  1. change stats.py to compute OLS based on Pseudo-Inverse & Compute Z-st… 

    …atistics
    @CesarCaballeroGaudes
    CesarCaballeroGaudes committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    904bc01 View commit details
    Browse the repository at this point in the history

  2. updating pca.py to same as tedana in upstream

    @CesarCaballeroGaudes
    CesarCaballeroGaudes committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    8587b79 View commit details
    Browse the repository at this point in the history

  3. Changed default compute_zvalues of get_coeffs to F

    Stefano Moia authored Nov 25, 2019
    Configuration menu
    Copy the full SHA
    1617d2a View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. LIntered and changed name of function get_coeff into compute_least_sq… 

    …uares, changed import in viz.py.
    smoia committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    2453c78 View commit details
    Browse the repository at this point in the history

  2. Changed orientation of "beta" matrix in RSS

    smoia committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    94cc77e View commit details
    Browse the repository at this point in the history

  3. Renmaed compute_least_squares into get_ls_coeffs

    smoia committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    b3baa52 View commit details
    Browse the repository at this point in the history

  4. Lintering and Removing part of code that is not needed anymore due to… 

    … normalisation of z_score happening inside get_ls_coeffs
    smoia committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    487416d View commit details
    Browse the repository at this point in the history

  5. Improved comments on what's going on in get_ls_coeffs

    smoia committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    b96c3b2 View commit details
    Browse the repository at this point in the history

  6. Corrected use of "due" in stats.py

    smoia committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    7061614 View commit details
    Browse the repository at this point in the history

  7. Corrected use of duecredit

    smoia committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    4820c19 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2019

  1. Merge pull request ME-ICA#1 from smoia/patch-1 

    Changed default compute_zvalues of get_coeffs to False
    @CesarCaballeroGaudes
    CesarCaballeroGaudes authored Nov 29, 2019
    Configuration menu
    Copy the full SHA
    1def734 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'OLS_stats_modification' into OLS_stats_modification

    @CesarCaballeroGaudes
    CesarCaballeroGaudes authored Nov 29, 2019
    Configuration menu
    Copy the full SHA
    ba3aa26 View commit details
    Browse the repository at this point in the history

  3. Merge pull request ME-ICA#2 from smoia/OLS_stats_modification 

    Modified get_coeffs into get_ls_coeffs, corrected its use in the code.
    @CesarCaballeroGaudes
    CesarCaballeroGaudes authored Nov 29, 2019
    Configuration menu
    Copy the full SHA
    2ec3b3c View commit details
    Browse the repository at this point in the history

  4. compute OLS with np.linalg.lstsq instead of np.linalg.pinv

    @CesarCaballeroGaudes
    CesarCaballeroGaudes committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    25b5ea3 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. Removed unused parameter from computefeats2

    smoia committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    8b03c2b View commit details
    Browse the repository at this point in the history

  2. Removed unused parameter

    smoia committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    88d049d View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Removed unused parameter

    smoia committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    adc2850 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Removed unused parameter

    smoia committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    f8dfc8b View commit details
    Browse the repository at this point in the history

  2. Added limits to betas and z_scores to avoid breaking code due to INFs.

    smoia committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    c679600 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'OLS_stats_modification' of github.com:smoia/tedana into… 

    … OLS_stats_modification
    smoia committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    2e2c63b View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into OLS_stats_modific… 

    …ation
    smoia committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    a4d2c35 View commit details
    Browse the repository at this point in the history

  5. Modified nan_to_num to clip in order to limit arrays, removed limit o… 

    …n betas.
    smoia committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    ae582b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Merge branch 'master' into OLS_stats_modification

    Stefano Moia committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    cd42798 View commit details
    Browse the repository at this point in the history

  2. Align indented line and keep the linter happy.

    Stefano Moia committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    d8bd355 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. Merge remote-tracking branch 'origin/main' into OLS_stats_modification

    Stefano Moia committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    4c85723 View commit details
    Browse the repository at this point in the history

  2. Rename computefeats2 as get_ls_zvalues

    Stefano Moia committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    8cfa3ca View commit details
    Browse the repository at this point in the history