-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIx CI #112
Merged
FIx CI #112
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8074367
FIx CI
IAlibay 3ef00f4
Update and rename readthedocs.yml to .readthedocs.yml
IAlibay 2ded495
Merge branch 'main' into fix-ci
IAlibay 7df0578
switch to importlib
IAlibay 956b058
Drop py3.8, add py3.12
IAlibay 1b6946f
fix CI
IAlibay 0a2de31
remove as_posix calls
IAlibay 7d9b6be
fix relative path issues
IAlibay eebf54a
pin to <7 sphinx
IAlibay 449ccc1
try fixing rtd
lilyminium f52a392
fix path
lilyminium a971874
add sphinx theme to req
lilyminium 70667de
upgrade mambaforge
lilyminium f764b14
fix header
lilyminium e1c5c7e
Merge branch 'fix-ci' into fix-rtd
lilyminium a48a030
Merge pull request #114 from MDAnalysis/fix-rtd
IAlibay 219cc31
missing init file?
IAlibay d2cf8d5
switch to micromamba action
IAlibay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# readthedocs.yml | ||
|
||
version: 2 | ||
|
||
sphinx: | ||
configuration: docs/conf.py | ||
|
||
build: | ||
os: ubuntu-22.04 | ||
tools: | ||
python: "mambaforge-22.9" | ||
|
||
python: | ||
install: | ||
- method: setuptools | ||
path: . | ||
|
||
conda: | ||
environment: docs/requirements.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? As far as I can tell,
micromamba list
is run for thesetup micromamba
step already.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm keeping the spirit of what the original CI file did (there was a conda list call here).
Generally having a step post install that tells you everything in the environment is a good idea though - it tells you if anything has changed through pip override
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, good point!