Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of CMSParser #4816

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

talagayev
Copy link
Member

@talagayev talagayev commented Dec 3, 2024

Partially Fixes #4268 Attempt

Changes made in this Pull Request:

  • Addition of CMSParser
  • Allows reading CMS Files and extracting atomnames, resnames, atomids, resids, segids

Currently the problem that I am facing is, that I have all of the necessary data as arrays, which I give into the
Topology as attrs, but somehow names is recognized correctly, while in the remainder only the first
item is recognized, thus each atom will belong to the first resname, resid and segid and I am not
sure what the reason is for the Topology only recognizing the first item for those and all for the atomnames

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4816.org.readthedocs.build/en/4816/

@pep8speaks
Copy link

Hello @talagayev! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 21:1: W293 blank line contains whitespace
Line 27:1: W293 blank line contains whitespace
Line 44:80: E501 line too long (89 > 79 characters)
Line 45:1: W293 blank line contains whitespace
Line 53:9: E265 block comment should start with '# '
Line 65:80: E501 line too long (88 > 79 characters)
Line 92:43: W291 trailing whitespace
Line 118:80: E501 line too long (95 > 79 characters)

Line 310:28: E231 missing whitespace after ','

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 55 lines in your changes missing coverage. Please review.

Project coverage is 86.21%. Comparing base (557f27d) to head (3602eec).

Files with missing lines Patch % Lines
package/MDAnalysis/topology/CMSParser.py 15.38% 55 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4816      +/-   ##
===========================================
+ Coverage    86.08%   86.21%   +0.12%     
===========================================
  Files          177      190      +13     
  Lines        21742    22875    +1133     
  Branches      3055     3065      +10     
===========================================
+ Hits         18717    19722    +1005     
- Misses        2593     2721     +128     
  Partials       432      432              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desmond trajectory reader
2 participants