Change test class name for ITP tests #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linter Bot Results:Hi @lilyminium! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
|
Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-01-24 11:07:18 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4440 +/- ##
===========================================
+ Coverage 93.36% 93.38% +0.02%
===========================================
Files 171 185 +14
Lines 21736 22850 +1114
Branches 4012 4012
===========================================
+ Hits 20293 21338 +1045
- Misses 954 1025 +71
+ Partials 489 487 -2 ☔ View full report in Codecov by Sentry. |
IAlibay
requested changes
Jan 24, 2024
lilyminium
force-pushed
the
lilyminium/fix-4439
branch
from
4f637e9 to
5894fe4
Compare
|
Yeah this doesn't feel like it's big enough to go in the Fixes category 😅 Thanks for the review @IAlibay -- just added myself to CHANGELOG! |
IAlibay
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4439
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4440.org.readthedocs.build/en/4440/