BENCH: fix time_geometric_selections #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes MDAnalysisgh-3519 * There is no good reason to keep the flags in the benchmark--this benchmark has been broken for over a year so we should just use the appropriate kwargs where possible and leave a `TODO` comment for core flags that we don't have a substitute for * better to have this running than hard failing all the time, even if we've lost one of the parametrization dimensions * if someone comes along with the confidence to say we can delete the `TODO` comment, then we can also delete some of the extra parametrization complexity of course [skip cirrus]
Linter Bot Results:Hi @tylerjereddy! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4360 +/- ##
==========================================
Coverage 93.37% 93.37%
==========================================
Files 170 184 +14
Lines 22340 23453 +1113
Branches 4085 4085
==========================================
+ Hits 20859 21899 +1040
- Misses 963 1036 +73
Partials 518 518 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Benchmarks expect flags #3519
There is no good reason to keep the flags in the benchmark--this benchmark has been broken for over a year so we should just use the appropriate kwargs where possible and leave a
TODOcomment for core flags that we don't have a substitute forbetter to have this running than hard failing all the time, even if we've lost one of the parametrization dimensions
if someone comes along with the confidence to say we can delete the
TODOcomment, then we can also delete some of the extra parametrization complexity of course[skip cirrus]
📚 Documentation preview 📚: https://mdanalysis--4360.org.readthedocs.build/en/4360/