-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make biopython an optional dependency #4332
Conversation
Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-11-07 09:18:44 UTC |
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4332 +/- ##
===========================================
- Coverage 93.37% 93.36% -0.01%
===========================================
Files 170 184 +14
Lines 22309 23433 +1124
Branches 4076 4079 +3
===========================================
+ Hits 20830 21879 +1049
- Misses 962 1036 +74
- Partials 517 518 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs a changelog entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nitpicks but LGTM
/azp run Azure_Tests Linux-Python39-64bit-full-wheel |
No pipelines are associated with this pull request. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Rocco Meli <[email protected]>
Fixes #3820
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4332.org.readthedocs.build/en/4332/