Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make biopython an optional dependency #4332

Merged
merged 11 commits into from
Nov 7, 2023
Merged

Make biopython an optional dependency #4332

merged 11 commits into from
Nov 7, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 3, 2023

Fixes #3820

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4332.org.readthedocs.build/en/4332/

@pep8speaks
Copy link

pep8speaks commented Nov 3, 2023

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1180:1: W293 blank line contains whitespace

Comment last updated at 2023-11-07 09:18:44 UTC

Copy link

github-actions bot commented Nov 3, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/6782384299/job/18434498431


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20013d8) 93.37% compared to head (ffa3a57) 93.36%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4332      +/-   ##
===========================================
- Coverage    93.37%   93.36%   -0.01%     
===========================================
  Files          170      184      +14     
  Lines        22309    23433    +1124     
  Branches      4076     4079       +3     
===========================================
+ Hits         20830    21879    +1049     
- Misses         962     1036      +74     
- Partials       517      518       +1     
Files Coverage Δ
package/MDAnalysis/analysis/align.py 96.48% <100.00%> (+0.10%) ⬆️
package/MDAnalysis/core/topologyattrs.py 96.15% <100.00%> (+0.02%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package/MDAnalysis/analysis/align.py Outdated Show resolved Hide resolved
package/MDAnalysis/analysis/align.py Outdated Show resolved Hide resolved
package/MDAnalysis/core/topologyattrs.py Outdated Show resolved Hide resolved
package/MDAnalysis/analysis/align.py Show resolved Hide resolved
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a changelog entry?

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nitpicks but LGTM

package/MDAnalysis/core/topologyattrs.py Outdated Show resolved Hide resolved
package/MDAnalysis/core/topologyattrs.py Outdated Show resolved Hide resolved
@RMeli
Copy link
Member

RMeli commented Nov 5, 2023

/azp run Azure_Tests Linux-Python39-64bit-full-wheel

Copy link

No pipelines are associated with this pull request.

@RMeli
Copy link
Member

RMeli commented Nov 5, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IAlibay IAlibay merged commit c36313e into develop Nov 7, 2023
21 of 22 checks passed
@IAlibay IAlibay deleted the drop_biopython branch November 7, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make biopython an optional dependency
3 participants