Minor QoL fixes and major compile time improvements #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve //update performance - Allow for plot wide //update - Update after paste with //paste -u - Improve /rtps u[nlimited] ergonomics
StackDoubleFlow
requested changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optimized function for iterating over all blocks inside a region, skipping all empty chunk sections.
This improves compile time speeds from ~200ms down to ~20ms on my machine for normal sized 256x256 plots.
Other changes:
//update//updatewithout a selection the entire plot is updated instead-uflag for the//pastecommand to immediately update the pasted schematic/rtps unow works as an alias for/rtps unlimitedI hope someone has a good idea on how to deduplicate the optimized function without introducing overhead.