Code

GH-744-Review-sub-2#553

Code

Open

Syther007 wants to merge 30 commits intoGH-744MASQ-Project/Node:GH-744from GH-744-Review-1MASQ-Project/Node:GH-744-Review-1Copy head branch name to clipboard

+1,320-2,172

Commits

Commits on Oct 21, 2024

• GH-744: Review-1 first lot of changes

  Syther007

  committed
  3d35b4c

  Copy full SHA for 3d35b4c

Commits on Oct 22, 2024

• GH-744: Review-1 - fixed more tests

  Syther007

  committed
  cc709be

  Copy full SHA for cc709be

• GH-744: improved wildcard IP check

  Syther007

  committed
  e9bddc8

  Copy full SHA for e9bddc8

• GH-744: removed unused imports

  Syther007

  committed
  b72c61b

  Copy full SHA for b72c61b

Commits on Oct 25, 2024

• GH-744: fixed a bunch more comments from review 1

  Syther007

  committed
  d4c5be9

  Copy full SHA for d4c5be9

Commits on Nov 1, 2024

• GH-744: resolved more review comments

  Syther007

  committed
  43456e7

  Copy full SHA for 43456e7

• GH-744: started converting gas_price units from gwei to wei

  Syther007

  committed
  4d7fa8a

  Copy full SHA for 4d7fa8a

Commits on Nov 4, 2024

• GH-744: finish converting gas price from gwei to wei

  Syther007

  committed
  6a3ceaf

  Copy full SHA for 6a3ceaf

• GH-744: Formating & removed warnings

  Syther007

  committed
  8f131bb

  Copy full SHA for 8f131bb

Commits on Nov 5, 2024

• GH-744: Added TransactionFailed to TransactionReceiptResult

  Syther007

  committed
  67a9786

  Copy full SHA for 67a9786

Commits on Nov 8, 2024

• GH-744: Migrated the guts of get_transaction_receipt_in_batch to process_transaction_receipts

  Syther007

  committed
  4db1f91

  Copy full SHA for 4db1f91

Commits on Nov 11, 2024

• GH-744: Moved submit_payables_in_batch to blockchain_interface

  Syther007

  committed
  b0aed3a

  Copy full SHA for b0aed3a

Commits on Nov 12, 2024

• GH-744: removed test: blockchain_bridge_can_return_report_transaction_receipts_with_an_empty_vector

  Syther007

  committed
  fac4936

  Copy full SHA for fac4936

Commits on Nov 13, 2024

• GH-744: Fixed a few more URGENCY comments

  Syther007

  committed
  c5ddb57

  Copy full SHA for c5ddb57

• GH-744: cleanup & formatting

  Syther007

  committed
  237a533

  Copy full SHA for 237a533

Commits on Nov 15, 2024

• GH-744: add some TODOs as discussed on Wed and Thu

  utkarshg6

  committed
  1be2642

  Copy full SHA for 1be2642

• GH-744: handle_request_transaction_receipts chaged error to a DEBUG log

  Syther007

  committed
  8d22c61

  Copy full SHA for 8d22c61

• GH-744: handle_retrieve_transactions inbeded extract_max_block_count

  Syther007

  committed
  b3cafe4

  Copy full SHA for b3cafe4

• GH-744: code refactor

  Syther007

  committed
  ab32fb6

  Copy full SHA for ab32fb6

Commits on Nov 18, 2024

• GH-744: removed transaction_id from Agent

  Syther007

  committed
  1a92588

  Copy full SHA for 1a92588

• GH-744: Removed get_gas_price from submit_batch call

  Syther007

  committed
  5172c82

  Copy full SHA for 5172c82

• GH-744: logger is now a reference in send_payables_within_batch

  Syther007

  committed
  89419ed

  Copy full SHA for 89419ed

• GH-744: send_payables_within_batch web3_batch is now a reference

  Syther007

  committed
  5181f1c

  Copy full SHA for 5181f1c

• GH-744: sign_and_append_multiple_payments accounts is now a reference

  Syther007

  committed
  54ab85e

  Copy full SHA for 54ab85e

Commits on Nov 19, 2024

• GH-744 removed Blockchan_interface_mock

  Syther007

  committed
  e93c0f1

  Copy full SHA for e93c0f1

Commits on Nov 20, 2024

• GH-744: Refactored all 4 test for send_payables_within_batch

  Syther007

  committed
  ef88ab4

  Copy full SHA for ef88ab4

• GH-744: cleanup & formatting

  Syther007

  committed
  f18b8a6

  Copy full SHA for f18b8a6

• GH-744: small fixs

  Syther007

  committed
  a5e6f68

  Copy full SHA for a5e6f68

Commits on Nov 22, 2024

• GH-744: handle_normal_client_data detects wildcard IP & localhost with error

  Syther007

  committed
  3d4f552

  Copy full SHA for 3d4f552

Commits on Nov 25, 2024

• GH-744: Finished all urgent comments

  Syther007

  committed
  4de72c8

  Copy full SHA for 4de72c8