This repository has been archived by the owner on Apr 10, 2024. It is now read-only.
Minor changes to the preexisting code that Grace discovered during her internship #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 1: In edsc_extension/src/index.ts, the following code was used:
let response: any = $.parseJSON(xhr.response);This line has become outdated so I replaced the line withlet response: any = JSON.parse(xhr.response);as Visual Studio code suggested. I also removed the import statement for jquery (import * as $ from "jquery";)Change 2: I frequently encountered problems when running 'npm run build
from the ipycmc readme. Adding in the file loaders to ipycmc/webpack.config.js allowed me to runnpm run build` successfully in both my Windows machine and Windows Subsystem for LinuxNote: These changes don't affect my project, they are just suggestions to preexisting code that I noticed during the course of my 2021 summer internship.