Refactor toggling to avoid duplicate upload #2693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
added
High Priority
tinohager
reviewed
Nov 17, 2024
There was a problem hiding this comment.
the code is duplicate props.config.value === "1", maybe you could save the result above in a const
There was a problem hiding this comment.
But a const would not be updated on a save of the value as done with the watch :/
tinohager
reviewed
Nov 17, 2024
| const trackLayer = ref(undefined as any); | ||
| const data = ref(undefined as undefined | App.Http.Resources.Collections.PositionDataResource); | ||
| const bounds = ref<LatLngBoundsLiteral | undefined>(undefined); | ||
| const photoLayer = ref<any>(undefined); |
There was a problem hiding this comment.
any is bad, is there no model that can be used?
There was a problem hiding this comment.
Yeah I know, but this is untyped code from a library. On that one not much chance, and I don't feel like typing the damn thing. :')
tinohager
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref()See in particular:
https://github.com/LycheeOrg/Lychee/pull/2693/files#diff-5585be2db0c41adcd345e27400e1476598e1979d611d3030d032d049f64f12e4
https://github.com/LycheeOrg/Lychee/pull/2693/files#diff-4fdc99a20d4bdd62b978a193d29a30934d64bf6ceb26f010bd441b9e9ac167db
TODO later: migrate the other booleans (rename etc) to that store.