Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run on 1.10 and 1 #43

Merged
merged 3 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .buildkite/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ steps:
matrix:
setup:
julia:
- "1.10"
- "1"

- group: ":telescope: Downstream CUDA"
Expand All @@ -40,7 +41,7 @@ steps:
queue: "juliagpu"
cuda: "*"
if: build.message !~ /\[skip tests\]/ && build.message !~ /\[skip downstream\]/ && build.message !~ /\[skip ci\]/ && build.pull_request.labels includes "run downstream test"
timeout_in_minutes: 60
timeout_in_minutes: 240
matrix:
setup:
repo:
Expand Down Expand Up @@ -70,10 +71,11 @@ steps:
rocm: "*"
rocmgpu: "*"
if: build.message !~ /\[skip tests\]/ && build.message !~ /\[skip ci\]/
timeout_in_minutes: 60
timeout_in_minutes: 240
matrix:
setup:
julia:
- "1.10"
- "1"

- group: ":telescope: Downstream AMD GPU"
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
fail-fast: false
matrix:
version:
- "min"
- "1"
os:
- ubuntu-latest
Expand Down Expand Up @@ -64,7 +65,7 @@ jobs:
name: Downstream ${{ matrix.package.repo }}/${{ matrix.package.group }}
if: ${{ !contains(github.event.head_commit.message, '[skip tests]') && contains(github.event.pull_request.labels.*.name, 'run downstream test') }}
runs-on: ${{ matrix.os }}
timeout-minutes: 60
timeout-minutes: 240
env:
GROUP: ${{ matrix.package.group }}
strategy:
Expand Down Expand Up @@ -122,7 +123,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: ["1"]
version: ["1.10"]
steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ ConcreteStructs = "0.2.3"
GPUArraysCore = "0.1.6"
GPUArrays = "10.2"
LinearAlgebra = "1.10"
Metal = "1.1.0"
Metal = "1.3.0"
Random = "1.10"
SpecialFunctions = "2.4"
Statistics = "1.10"
Expand Down
8 changes: 3 additions & 5 deletions test/initializers_tests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ end
init === randn32) &&
continue

if (backend == "oneapi" || backend == "metal") && init === truncated_normal
if backend == "oneapi" && init === truncated_normal
@test_broken size(init(rng, 3)) == (3,) # `erfinv` not implemented
continue
end
Expand Down Expand Up @@ -229,9 +229,7 @@ end

init === truncated_normal && !(T <: Real) && continue

if (backend == "oneapi" || backend == "metal") &&
init === truncated_normal &&
T == Float32
if backend == "oneapi" && init === truncated_normal && T == Float32
@test_broken init(rng, T, 3) isa AbstractArray{T, 1} # `erfinv` not implemented
continue
end
Expand Down Expand Up @@ -261,7 +259,7 @@ end
@testset "Closure: $init" for init in [
kaiming_uniform, kaiming_normal, glorot_uniform,
glorot_normal, truncated_normal, identity_init]
if (backend == "oneapi" || backend == "metal") && init === truncated_normal
if backend == "oneapi" && init === truncated_normal
@test_broken size(init(rng, 3)) == (3,) # `erfinv` not implemented
continue
end
Expand Down
Loading