Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move ChainRulesCore into an extension #36

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Aug 21, 2024

ChainRulesCore isn't needed by the core framework, but still adds some load time. Anyone requiring the functionality will have loaded it by default...

julia> @time using WeightInitializers
  0.040279 seconds (43.41 k allocations: 3.302 MiB)  # NOW

julia> @time using WeightInitializers
  0.060959 seconds (63.61 k allocations: 4.682 MiB)  # BEFORE

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.80%. Comparing base (0d95f4a) to head (129a516).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   93.80%   93.80%           
=======================================
  Files           9        9           
  Lines         210      210           
=======================================
  Hits          197      197           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal merged commit f7a95d8 into main Aug 21, 2024
18 checks passed
@avik-pal avik-pal deleted the ap/crc_ext branch August 21, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant