Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LUX.jl/examples/SimpleRNN/main.jl #1240

Merged
merged 3 commits into from
Feb 22, 2025

Conversation

aligurbu
Copy link
Contributor

Don't I need to have "using Zygote" for this code to work since it is called AutoZygote() on line 149?

Don't I need to have "using Zygote" for this code to work since it is called `AutoZygote()` on line 149?
@avik-pal
Copy link
Member

Don't I need to have "using Zygote" for this code to work since it is called AutoZygote() on line 149?

you are right. Let's add this as a comment, else we will have to add Zygote to the project deps, and we have been actively trying to cut down on the Zygote dependencies

Include comment on Zygote usage for 'AutoZygote()'.
@aligurbu
Copy link
Contributor Author

Hello Avik,
I am unsure. Are the comments that I added what you meant to have instead?
Thanks.

Copy link
Contributor Author

@aligurbu aligurbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@avik-pal avik-pal merged commit a979d4f into LuxDL:main Feb 22, 2025
11 of 13 checks passed
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.92%. Comparing base (e8f1963) to head (6f1ac5b).
Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (e8f1963) and HEAD (6f1ac5b). Click for more details.

HEAD has 48 uploads less than BASE
Flag BASE (e8f1963) HEAD (6f1ac5b)
49 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1240       +/-   ##
===========================================
- Coverage   84.61%   36.92%   -47.69%     
===========================================
  Files         153       58       -95     
  Lines        6317     3022     -3295     
===========================================
- Hits         5345     1116     -4229     
- Misses        972     1906      +934     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aligurbu aligurbu deleted the aligurbu-patch-1 branch February 22, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants