Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable exclusion notification on pyluos side by the gate #454

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

nicolas-rabault
Copy link
Member

@nicolas-rabault nicolas-rabault commented Dec 8, 2023

By submiting this PR, you agree with the associated license (Apache 2.0 or MIT) and with our Contributor License Agreement (CLA).

Before to begin

Thank you for contributing to the Luos project!

Before to begin, please follow these steps:

  • Ensure that this PR is not a duplicate.
  • Assign @Simonbdy to this PR
  • Add the PR to the Luos contribution project

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.

PR Description section

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • New feature (non-breaking change which adds functionality)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault added advanced Advanced skills are needed for this subject multi-phy Deal with multiple network at the same time labels Dec 8, 2023
@nicolas-rabault nicolas-rabault added this to the 3.0.0 milestone Dec 8, 2023
@nicolas-rabault nicolas-rabault self-assigned this Dec 8, 2023
@nicolas-rabault nicolas-rabault changed the title Re-enable exclusion notification on pyluos side byt the gate Re-enable exclusion notification on pyluos side by the gate Dec 8, 2023
@nicolas-rabault nicolas-rabault merged commit 7773eb2 into rc_3.0.0 Dec 8, 2023
46 of 52 checks passed
@nicolas-rabault nicolas-rabault deleted the feat/gate_exclusion branch December 8, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced Advanced skills are needed for this subject multi-phy Deal with multiple network at the same time
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant