fix(table): avoid row height change #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, re-renderings after the initial render, or changes within components in the table cells, or clicking on rows, or size of the components in the table cells would cause a resize on all rows in a table. This always resulted in reduced quality of the experience. This fix might break some carelessly designed UIs of custom components used in table views. But since we have so many issues with this, and fixing other issues relies on having a fixed row height, consumers have to adapt.
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3401/ |
LucyChyzhova
approved these changes
Jan 16, 2025
|
🎉 This PR is included in version 37.79.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, re-renderings after the initial render, or changes within components in the table cells, or
clicking on rows, or size of the components in the table cells would cause a resize on all rows in a table. This always resulted in reduced quality of the experience. This fix might break some carelessly designed UIs of custom components used in table views.
But since we have so many issues with this,
and fixing other issues relies on having a fixed row height, consumers have to adapt.
fix https://github.com/Lundalogik/crm-feature/issues/4571
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: