Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 #3398

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

React 19 #3398

wants to merge 5 commits into from

Conversation

vicgeralds
Copy link
Contributor

  • Updates to React 19 which comes with better support for rendering custom elements
  • Removes LimeElementsAdapter that's used for rendering custom elements in rjsf forms

This is a fix, because LimeElementsAdapter set some properties later depending on their type, meaning they were set later than expected in some situations or in unexpected order.

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

Copy link

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3398/

@vicgeralds vicgeralds marked this pull request as ready for review January 14, 2025 10:08
@vicgeralds vicgeralds requested a review from a team as a code owner January 14, 2025 10:08
@vicgeralds vicgeralds force-pushed the react-19 branch 3 times, most recently from 19dc4cf to 4d3328b Compare January 14, 2025 13:50
It's no longer needed when using React 19 which has much better support
for rendering custom elements.

This is a fix, because LimeElementsAdapter set some properties later
depending on their type, meaning they were set later than expected in
some situations or in unexpected order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant