-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for displaying pictures in the list items #3392
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,109 @@ | ||
import { ListItem } from '@limetech/lime-elements'; | ||
import { Component, h, State } from '@stencil/core'; | ||
|
||
/** | ||
* List with Pictures and Icons | ||
* | ||
* :::note | ||
* While it's technically possible to display both images and icons simultaneously | ||
* for each list item, we recommend against using identical icons across all items. | ||
* Repeating the same icon for every list item adds unnecessary visual clutter | ||
* without providing additional value. | ||
* | ||
* Icons, like images, should serve to help users quickly differentiate between | ||
* list items. They are most effective when each icon uniquely identifies | ||
* the type or category of its list item. | ||
* ::: | ||
*/ | ||
@Component({ | ||
tag: 'limel-example-list-pictures', | ||
shadow: true, | ||
}) | ||
export class PictureListExample { | ||
private items: Array<ListItem<number>> = [ | ||
{ | ||
text: 'Lucy Chyzhova', | ||
secondaryText: 'UX Designer', | ||
value: 1, | ||
icon: { | ||
name: 'santas_hat', | ||
color: 'rgb(var(--color-coral-default))', | ||
}, | ||
image: { | ||
src: 'https://lundalogik.github.io/lime-elements/780af2a6-d3d1-4593-8642-f03210d09271.png', | ||
alt: 'A picture of Lucy Chyzhova, UX designer at Lime Technologies', | ||
}, | ||
}, | ||
{ | ||
text: 'Kiarokh Moattar', | ||
secondaryText: 'Product Designer', | ||
value: 2, | ||
icon: { | ||
name: 'party_hat', | ||
color: 'rgb(var(--color-pink-default))', | ||
}, | ||
image: { | ||
src: 'https://lundalogik.github.io/lime-elements/2e86c284-d190-4c41-8da2-4de50103a0cd.png', | ||
alt: 'A picture of Kiarokh Moattar, Product Designer at Lime Technologies', | ||
}, | ||
}, | ||
{ | ||
text: 'Adrian Schmidt', | ||
secondaryText: 'Engineer', | ||
value: 3, | ||
icon: 'viking_helmet', | ||
image: { | ||
src: 'https://lundalogik.github.io/lime-elements/0e6f74c0-11d9-465b-aac6-44f33da3cb7c.png', | ||
alt: 'A picture of Adrian Schmidt, Head of Smooth Operations at Lime Technologies', | ||
}, | ||
}, | ||
{ | ||
text: 'Befkadu Degefa', | ||
secondaryText: 'Engineer', | ||
value: 4, | ||
icon: { | ||
name: 'bowler_hat', | ||
color: 'rgb(var(--color-sky-default))', | ||
}, | ||
}, | ||
]; | ||
|
||
@State() | ||
private badgeIcons: boolean = false; | ||
|
||
@State() | ||
private hasStripedRows: boolean = true; | ||
|
||
public render() { | ||
return [ | ||
<limel-list | ||
items={this.items} | ||
type="selectable" | ||
badgeIcons={this.badgeIcons} | ||
class={this.hasStripedRows ? 'has-striped-rows' : ''} | ||
/>, | ||
<limel-example-controls> | ||
<limel-checkbox | ||
checked={this.badgeIcons} | ||
label="badge icons" | ||
onChange={this.setBadgeIcons} | ||
/> | ||
<limel-checkbox | ||
checked={this.hasStripedRows} | ||
label="striped rows" | ||
onChange={this.setHasStripedRows} | ||
/> | ||
</limel-example-controls>, | ||
]; | ||
} | ||
|
||
private setBadgeIcons = (event: CustomEvent<boolean>) => { | ||
event.stopPropagation(); | ||
this.badgeIcons = event.detail; | ||
}; | ||
|
||
private setHasStripedRows = (event: CustomEvent<boolean>) => { | ||
event.stopPropagation(); | ||
this.hasStripedRows = event.detail; | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
import { LimelPickerCustomEvent, ListItem } from '@limetech/lime-elements'; | ||
import { Component, h, State } from '@stencil/core'; | ||
|
||
/** | ||
* With pictures | ||
*/ | ||
@Component({ | ||
tag: 'limel-example-picker-pictures', | ||
shadow: true, | ||
}) | ||
export class PickerPicturesExample { | ||
@State() | ||
private selectedItems: Array<ListItem<number>> = []; | ||
|
||
private allItems: Array<ListItem<number>> = [ | ||
{ | ||
text: 'Lucy Chyzhova', | ||
secondaryText: 'UX Designer', | ||
value: 1, | ||
icon: { | ||
name: 'santas_hat', | ||
color: 'rgb(var(--color-coral-default))', | ||
}, | ||
image: { | ||
src: 'https://lundalogik.github.io/lime-elements/780af2a6-d3d1-4593-8642-f03210d09271.png', | ||
alt: 'A picture of Lucy Chyzhova, UX designer at Lime Technologies', | ||
}, | ||
}, | ||
{ | ||
text: 'Kiarokh Moattar', | ||
secondaryText: 'Product Designer', | ||
value: 2, | ||
icon: { | ||
name: 'party_hat', | ||
color: 'rgb(var(--color-pink-default))', | ||
}, | ||
image: { | ||
src: 'https://lundalogik.github.io/lime-elements/2e86c284-d190-4c41-8da2-4de50103a0cd.png', | ||
alt: 'A picture of Kiarokh Moattar, Product Designer at Lime Technologies', | ||
}, | ||
}, | ||
{ | ||
text: 'Adrian Schmidt', | ||
secondaryText: 'Engineer', | ||
value: 3, | ||
icon: 'viking_helmet', | ||
image: { | ||
src: 'https://lundalogik.github.io/lime-elements/0e6f74c0-11d9-465b-aac6-44f33da3cb7c.png', | ||
alt: 'A picture of Adrian Schmidt, Head of Smooth Operations at Lime Technologies', | ||
}, | ||
}, | ||
{ | ||
text: 'Befkadu Degefa', | ||
secondaryText: 'Engineer', | ||
value: 4, | ||
icon: { | ||
name: 'bowler_hat', | ||
color: 'rgb(var(--color-sky-default))', | ||
}, | ||
}, | ||
]; | ||
|
||
public render() { | ||
return [ | ||
<limel-picker | ||
label="Favorite awesomenaut" | ||
value={this.selectedItems} | ||
searchLabel={'Search your awesomenaut'} | ||
multiple={true} | ||
allItems={this.allItems} | ||
emptyResultMessage="No matching awesomenauts found" | ||
onChange={this.onChange} | ||
onInteract={this.onInteract} | ||
/>, | ||
<limel-example-value value={this.selectedItems} />, | ||
]; | ||
} | ||
|
||
private onChange = ( | ||
event: LimelPickerCustomEvent<Array<ListItem<number>>>, | ||
) => { | ||
this.selectedItems = [...event.detail]; | ||
}; | ||
|
||
private onInteract = (event: LimelPickerCustomEvent<ListItem<number>>) => { | ||
console.log('Value interacted with:', event.detail); | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know this is auto generated, but it just felt weird that it says
Image_2
. Did we do something wrong, or is this correct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea it is auto generated running the command
npm run api:update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. I'm not sure if I've seen that in this file before. I know I've seen it somewhere, but I'm fairly sure that's been in
components.d.ts
. In this case, I findImage_2
referenced indist/lime-elements.d.ts
, but I can't seem to find where it's actually coming from.I've tried removing the existing
dist
folder and other temporary folders, and run the build andapi:update
script again, but just got the same result anyway.It's exported as
Image
anyway, so it shouldn't be a problem: