Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release limel-file-viewer publicly as a beta #3378

Merged
merged 7 commits into from
Dec 20, 2024
Merged

Conversation

Kiarokh
Copy link
Contributor

@Kiarokh Kiarokh commented Dec 20, 2024

Just realized that the limel-file-viewer component that @anderssonjohan and @LucyChyzhova and I made like ages ago, has been @private since then. Wonder why nobody uses it in their awesome creations.

Back then, we didn’t use the @beta tag, and had this next version, which was expected to be unstable and buggy, and the latest version which was supposed to be the stable one.

So, we used to use the @private tag to keep things that were potentially buggy, away from the stable versions.

These days, we use @beta for things that are still untested and may be buggy; and there is no next version anymore.

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

@Kiarokh Kiarokh self-assigned this Dec 20, 2024
Copy link

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3378/

@Kiarokh Kiarokh force-pushed the file-viewer-release branch from bef1481 to d4beb01 Compare December 20, 2024 09:54
* @exampleComponent limel-example-file-viewer-office
* @exampleComponent limel-example-file-viewer-filename
* @exampleComponent limel-example-file-viewer-inbuilt-actions
* @exampleComponent limel-example-file-viewer-custom-actions
* @exampleComponent limel-example-file-viewer-with-picker
* @private
*
* @beta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run npm run api:update 🤗

@adrianschmidt adrianschmidt requested a review from a team as a code owner December 20, 2024 10:17
@Kiarokh Kiarokh enabled auto-merge (rebase) December 20, 2024 10:20
@adrianschmidt adrianschmidt enabled auto-merge (rebase) December 20, 2024 10:20
@adrianschmidt adrianschmidt merged commit 9880c0f into main Dec 20, 2024
12 checks passed
@adrianschmidt adrianschmidt deleted the file-viewer-release branch December 20, 2024 10:20
@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.77.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants