-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release limel-file-viewer
publicly as a beta
#3378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for consistency with other components
…Fs in examples Previously, files where hosted at Lime Technologies's website, which would result in broken links, once they were removed.
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3378/ |
Kiarokh
force-pushed
the
file-viewer-release
branch
from
December 20, 2024 09:54
bef1481
to
d4beb01
Compare
* @exampleComponent limel-example-file-viewer-office | ||
* @exampleComponent limel-example-file-viewer-filename | ||
* @exampleComponent limel-example-file-viewer-inbuilt-actions | ||
* @exampleComponent limel-example-file-viewer-custom-actions | ||
* @exampleComponent limel-example-file-viewer-with-picker | ||
* @private | ||
* | ||
* @beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to run npm run api:update
🤗
adrianschmidt
force-pushed
the
file-viewer-release
branch
from
December 20, 2024 10:17
d4beb01
to
db2a91d
Compare
adrianschmidt
approved these changes
Dec 20, 2024
🎉 This PR is included in version 37.77.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realized that the
limel-file-viewer
component that @anderssonjohan and @LucyChyzhova and I made like ages ago, has been@private
since then. Wonder why nobody uses it in their awesome creations.Back then, we didn’t use the
@beta
tag, and had thisnext
version, which was expected to be unstable and buggy, and thelatest
version which was supposed to be the stable one.So, we used to use the
@private
tag to keep things that were potentially buggy, away from the stable versions.These days, we use
@beta
for things that are still untested and may be buggy; and there is nonext
version anymore.Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: