fix(text-editor): avoid occasional null reference error #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3373/ |
|
Ah yes, I've seen this error occasionally as well. |
john-traas
approved these changes
Dec 18, 2024
|
🎉 This PR is included in version 37.76.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a commit I had on a branch which I later abandoned. Because it has been a while since I made the change, I don't actually remember how to reproduce this null reference error, but it happened when I was looking into the trigger not working on iOS, and so I thought I'd just add optional chaining to try to avoid the error.
I managed to reproduce it while playing around with inserting html while the editor was in html content mode:
I had inserted a "mention", and then backspaced to delete it, and I think it was when I deleted the last thing in the editor (the blank line that had been inserted by the html-insertion, not sure if that's a
<br>or a<p></p>).I was not able to consistently reproduce it though 😕 🤷♂️
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: