Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-editor): don't show placeholder when composer is active #3363

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

LucyChyzhova
Copy link
Contributor

fix: https://github.com/Lundalogik/crm-feature/issues/4519

Screen.Recording.2024-12-10.at.13.40.55.mov

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

Copy link

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3363/

Copy link
Contributor

@adrianschmidt adrianschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
But also 😭… This feels like a hack upon a hack… I wonder how long it will take before someone complains about the placeholder disappearing before you've written anything 😒

@adrianschmidt adrianschmidt merged commit 8aba357 into main Dec 10, 2024
12 checks passed
@adrianschmidt adrianschmidt deleted the editor-placeholder-focused branch December 10, 2024 13:20
@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.75.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants