Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump the lint group across 1 directory with 5 updates #3335

Closed
wants to merge 3 commits into from
Closed

chore(deps-dev): bump the lint group across 1 directory with 5 updates #3335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da08cbd
chore(deps-dev): bump the lint group across 1 directory with 5 updates
dependabot[bot] Dec 2, 2024
c9c4ea2
chore(eslint): disable two rules that caused the linter to crash
adrianschmidt Dec 2, 2024
fc8821b
style(lint): automatic lint fixes
adrianschmidt Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ sonarjs.configs.recommended,
"sonarjs/new-cap": "warn",
"sonarjs/no-clear-text-protocols": "error",
"sonarjs/no-commented-code": "warn",
"sonarjs/no-empty-function": "warn",
"sonarjs/no-empty-function": "off", // Crashes eslint.
"sonarjs/no-invalid-await": "off", // This rule gives lots of false positives.
"sonarjs/no-invariant-returns": "warn",
"sonarjs/no-misused-promises": "warn",
Expand All @@ -163,6 +163,7 @@ sonarjs.configs.recommended,
"sonarjs/no-selector-parameter": "warn",
"sonarjs/no-skipped-test": "warn",
"sonarjs/no-unknown-property": "off", // This rule is incompatible with Stencil.
"sonarjs/no-unused-expressions": "off", // Crashes eslint. Probably incompatible with @typescript-eslint/no-unused-expressions?
"sonarjs/object-alt-content": "warn",
"sonarjs/prefer-nullish-coalescing": "off", // This rule requires the `strictNullChecks` compiler option to be turned on to function correctly. We probably want this, but it will be a huge job, and it might be a breaking change too.
"sonarjs/prefer-promise-shorthand": "warn",
Expand Down
400 changes: 207 additions & 193 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
"lint": "npm run lint:src && npm run lint:scss",
"lint:fix": "npm run lint:src:fix && npm run lint:scss:fix",
"lint:prod": "npm run lint:src:prod && npm run lint:scss:prod",
"lint:src": "eslint \"**/*.{ts,tsx,js}\" --max-warnings=655 && prettier -c \"{!(package*).json,.prettierrc}\"",
"lint:src": "eslint \"**/*.{ts,tsx,js}\" --max-warnings=651 && prettier -c \"{!(package*).json,.prettierrc}\"",
"lint:src:fix": "eslint \"**/*.{ts,tsx,js}\" --fix && prettier --write \"{!(package*).json,.prettierrc}\"",
"lint:src:prod": "eslint \"**/*.{ts,tsx,js}\" --rule \"linebreak-style: [error, unix]\" --max-warnings=655 && prettier -c \"{!(package*).json,.prettierrc}\"",
"lint:src:prod": "eslint \"**/*.{ts,tsx,js}\" --rule \"linebreak-style: [error, unix]\" --max-warnings=651 && prettier -c \"{!(package*).json,.prettierrc}\"",
"lint:scss": "prettier -c --ignore-path ./.gitignore **/*.scss",
"lint:scss:fix": "prettier --write --ignore-path ./.gitignore **/*.scss",
"lint:scss:prod": "prettier -c --end-of-line lf --ignore-path ./.gitignore **/*.scss",
Expand Down Expand Up @@ -59,19 +59,19 @@
"@types/react": "^18.3.12",
"@types/react-dom": "^18.3.1",
"@types/tabulator-tables": "^4.9.4",
"@typescript-eslint/eslint-plugin": "^8.14.0",
"@typescript-eslint/parser": "^8.14.0",
"@typescript-eslint/eslint-plugin": "^8.16.0",
"@typescript-eslint/parser": "^8.16.0",
"codemirror": "^5.65.9",
"cross-env": "^7.0.3",
"dayjs": "^1.11.13",
"eslint": "^9.14.0",
"eslint": "^9.16.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-ban": "^1.6.0",
"eslint-plugin-prefer-arrow": "^1.2.3",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-react": "^7.37.2",
"eslint-plugin-sonarjs": "^2.0.4",
"eslint-plugin-tsdoc": "^0.3.0",
"eslint-plugin-tsdoc": "^0.4.0",
"flatpickr": "^4.6.13",
"globals": "^15.12.0",
"html-escaper": "^3.0.3",
Expand All @@ -85,7 +85,7 @@
"moment": "^2.30.1",
"number-abbreviate": "^2.0.0",
"parse-css-color": "^0.2.1",
"prettier": "^3.3.3",
"prettier": "^3.4.1",
"prosemirror-example-setup": "^1.2.3",
"prosemirror-markdown": "^1.13.1",
"prosemirror-model": ">=1.22.1",
Expand Down
10 changes: 8 additions & 2 deletions src/components/chart/partial-styles/_area_line.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@
transform: translateX(-50%) translateY(50%);
left: 0;
bottom: calc(
(var(--limel-chart-item-size) + var(--limel-chart-item-offset)) *
(
var(--limel-chart-item-size) +
var(--limel-chart-item-offset)
) *
1%
);
}
Expand All @@ -60,7 +63,10 @@
&:after {
transform: translateX(-50%) translateY(-50%);
left: calc(
(var(--limel-chart-item-size) + var(--limel-chart-item-offset)) *
(
var(--limel-chart-item-size) +
var(--limel-chart-item-offset)
) *
1%
);
}
Expand Down
6 changes: 2 additions & 4 deletions src/components/shortcut/shortcut.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,11 @@
a {
all: unset;
@include mixins.is-elevated-clickable(
$background-color:
var(
$background-color: var(
--shortcut-background-color,
var(--lime-elevated-surface-background-color)
),
$background-color--hovered:
var(
$background-color--hovered: var(
--shortcut-background-color,
var(--lime-elevated-surface-background-color)
)
Expand Down
2 changes: 1 addition & 1 deletion src/style/internal/lime-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
// $text-secondary-on-dark: rgba(255, 255, 255, 0.7),
// $text-hint-on-dark: rgba(255, 255, 255, 0.5),
// $text-disabled-on-dark: rgba(255, 255, 255, 0.5),
// $text-icon-on-dark: rgba(255, 255, 255, 0.5),
// $text-icon-on-dark: rgba(255, 255, 255, 0.5),
);
@forward '@material/theme';

Expand Down
12 changes: 8 additions & 4 deletions src/style/shadows.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
// Same as above, but when element is indicating error or warning
--shadow-depth-8-error: var(--shadow-depth-8), var(--shadow-error-state);
// Same as above, but light source is below the element, good for bottom bars, etc...
--shadow-depth-8-reversed: 0 -0.2rem 0.45rem 0 rgb(var(--color-black), 0.132),
--shadow-depth-8-reversed: 0 -0.2rem 0.45rem 0
rgb(var(--color-black), 0.132),
0 -0.0375rem 0.1125rem 0 rgb(var(--color-black), 0.108);

// Good for Teaching callouts, Search results dropdown, cards, Tooltips
Expand All @@ -64,19 +65,22 @@
--shadow-depth-64-focused: var(--shadow-depth-64),
var(--shadow-focused-state);

--shadow-inflated-8: -0.125rem -0.125rem 0.375rem rgb(var(--color-black), 0.01),
--shadow-inflated-8: -0.125rem -0.125rem 0.375rem
rgb(var(--color-black), 0.01),
-0.25rem -0.25rem 0.625rem rgb(var(--color-white), 0.6),
0.25rem 0.25rem 0.625rem rgb(var(--color-black), 0.05),
0.0625rem 0.0625rem 0.625rem rgb(var(--color-white), 0.7),
-1px -1px 0 1px rgb(var(--color-black), 0.07) inset,
0 0 1px 1px rgb(var(--color-white), 0.98) inset;
--shadow-inflated-16: -0.1875rem -0.1875rem 0.375rem rgb(var(--color-black), 0.01),
--shadow-inflated-16: -0.1875rem -0.1875rem 0.375rem
rgb(var(--color-black), 0.01),
-0.375rem -0.375rem 1rem rgb(var(--color-white), 0.8),
0.375rem 0.375rem 1rem rgb(var(--color-black), 0.05),
0.125rem 0.125rem 0.625rem rgb(var(--color-white), 0.7),
-1px -1px 0 1px rgb(var(--color-black), 0.07) inset,
0 0 1px 1px rgb(var(--color-white), 0.98) inset;
--shadow-inflated-64: -0.1875rem -0.1875rem 0.375rem rgb(var(--color-black), 0.01),
--shadow-inflated-64: -0.1875rem -0.1875rem 0.375rem
rgb(var(--color-black), 0.01),
-0.625rem -0.625rem 1.875rem rgb(var(--color-white), 1),
0.625rem 0.625rem 2.25rem rgb(var(--color-black), 0.06),
0.125rem 0.125rem 0.625rem rgb(var(--color-white), 0.7),
Expand Down
Loading