Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limel-3d-hover-effect-glow as a @private internal component & use it #3330

Merged
merged 5 commits into from
Jan 7, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(card): use limel-3d-hover-effect-glow and DRY
  • Loading branch information
Kiarokh authored and adrianschmidt committed Jan 7, 2025
commit d3ca4c1be725e937963c2dd07941a929618b8b6e
7 changes: 3 additions & 4 deletions src/components/card/card.scss
Original file line number Diff line number Diff line change
@@ -137,10 +137,9 @@ limel-action-bar {
}

// The 3D effect
@include mixins.limel-3d-hover-effect-glow(
section,
var(--card-border-radius, $default-border-radius)
);
limel-3d-hover-effect-glow {
border-radius: var(--card-border-radius, $default-border-radius);
}

:host(limel-card) {
@include mixins.parent-of-the-3d-element;
2 changes: 1 addition & 1 deletion src/components/card/card.tsx
Original file line number Diff line number Diff line change
@@ -124,7 +124,7 @@ export class Card {
{this.renderValue()}
{this.renderActionBar()}
</div>
<div class="limel-3d-hover-effect-glow" />
<limel-3d-hover-effect-glow />
</section>
</Host>
);