Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(.eslintrc.js): adjust path regex for which files to consider examples #2765

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

adrianschmidt
Copy link
Contributor

@adrianschmidt adrianschmidt commented Feb 5, 2024

fix: #2766

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

@adrianschmidt adrianschmidt requested a review from jgroth February 5, 2024 15:03
@adrianschmidt adrianschmidt force-pushed the broaden-examples-exception branch from 4d1f646 to 8f1bb43 Compare February 5, 2024 15:05
Copy link

github-actions bot commented Feb 5, 2024

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2765/

'src/components/**/examples/*.{ts,tsx}',
'src/components/**/examples/**/*.{ts,tsx}',
'src/**/examples/*.{ts,tsx}',
'src/**/examples/**/*.{ts,tsx}',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't too broad, is it? @jgroth

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it should be fine 🙂

@adrianschmidt adrianschmidt mentioned this pull request Feb 5, 2024
13 tasks
@adrianschmidt adrianschmidt enabled auto-merge (rebase) February 5, 2024 15:09
@adrianschmidt adrianschmidt merged commit 8ae33f1 into main Feb 6, 2024
11 checks passed
@adrianschmidt adrianschmidt deleted the broaden-examples-exception branch February 6, 2024 07:26
@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for no-restricted-imports lint rule
3 participants