Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): show empty result when no search hits #2708

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

TommyLindh2
Copy link
Contributor

@TommyLindh2 TommyLindh2 commented Jan 12, 2024

Fixes #2660

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

Copy link

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2708/

@adrianschmidt adrianschmidt enabled auto-merge (rebase) January 12, 2024 14:52
@adrianschmidt adrianschmidt merged commit 81b3e22 into next Jan 12, 2024
11 checks passed
@adrianschmidt adrianschmidt deleted the fix/2660-show-empty-message-when-no-search-hits branch January 12, 2024 14:52
@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.1.0-next.88 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.2.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limel-menu searcher returns wrong result when there are no search hits
3 participants