Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper-line): when hidden, it should not have any height #2587

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

Kiarokh
Copy link
Contributor

@Kiarokh Kiarokh commented Nov 3, 2023

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

Copy link

github-actions bot commented Nov 3, 2023

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2587/

Befkadu1
Befkadu1 previously approved these changes Nov 3, 2023
@Kiarokh Kiarokh enabled auto-merge (rebase) November 3, 2023 16:00
@Kiarokh Kiarokh merged commit 0d68c6d into next Nov 3, 2023
11 checks passed
@Kiarokh Kiarokh deleted the empty-helper-line branch November 3, 2023 16:04
@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.1.0-next.53 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants