-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/limel menu cascading items #2473
Conversation
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2473/ |
2b3c8d8
to
e704f63
Compare
e704f63
to
17fb3b1
Compare
17fb3b1
to
b88c763
Compare
25af00d
to
cb40e0b
Compare
cd44fa4
to
62561be
Compare
c310b18
to
2ab5a2a
Compare
2607213
to
da7fe3f
Compare
7f72b0b
to
c8ca354
Compare
453d11b
to
5251e58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why there are spaces in some random places 😄
a285990
to
1048174
Compare
There seems to be a few comments from Johan that are not answered yet. After fixing them, I’d suggest that you squash all the fixup commits, and then split the PR into to few meaningful PRs that can be reviewed and merged separately. This makes the work less scary for the reviewers. For example, you can have one PR for enabling search, with a couple of examples. Which one you put up first for review is up to you. You know better how things are connected. Just keep in mind that the repo should be able to run or be deployed free of bugs or problems, after each commit that you add. |
61dddd3
to
1ff48ec
Compare
1ff48ec
to
c75f289
Compare
c75f289
to
bc222b9
Compare
This PR have been through a lot and it looks like it's huge when looking at the comments. |
fix: https://github.com/Lundalogik/solution-helpdesk-poc/issues/23
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: