Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(help): add new component #2291

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

Kiarokh
Copy link
Contributor

@Kiarokh Kiarokh commented May 9, 2023

Specially Intended to be used here: #2622

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

@github-actions
Copy link

github-actions bot commented May 9, 2023

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2291/

@Kiarokh Kiarokh force-pushed the create-helper-text-component branch 2 times, most recently from af15076 to f618417 Compare May 10, 2023 15:32
@civing civing force-pushed the create-helper-text-component branch from f618417 to 72decf5 Compare May 10, 2023 16:14
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need all the possible field types here to test the placement of the (?)

@Kiarokh Kiarokh force-pushed the create-helper-text-component branch 4 times, most recently from 55e5715 to 63718fa Compare November 10, 2023 13:20
@Kiarokh Kiarokh force-pushed the create-helper-text-component branch 7 times, most recently from 0849f7f to 640f70a Compare November 17, 2023 14:58
@Kiarokh Kiarokh marked this pull request as ready for review November 17, 2023 14:58
@Kiarokh Kiarokh force-pushed the create-helper-text-component branch from 640f70a to 17633ab Compare November 17, 2023 15:08
@Kiarokh
Copy link
Contributor Author

Kiarokh commented Nov 17, 2023

Specially Intended to be used here: #2622
If you wanna see that, check it out

@Kiarokh Kiarokh removed their assignment Nov 17, 2023
@Kiarokh Kiarokh force-pushed the create-helper-text-component branch from 17633ab to 3277bea Compare November 23, 2023 09:37
Co-authored-by: Kiarokh Moattar <[email protected]>
Co-authored-by: Lucy Chyzhova <[email protected]>
@adrianschmidt adrianschmidt force-pushed the create-helper-text-component branch from 3277bea to b774d85 Compare December 18, 2023 13:41
Copy link
Contributor

@adrianschmidt adrianschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@adrianschmidt adrianschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@adrianschmidt adrianschmidt merged commit 431db0f into next Dec 18, 2023
11 checks passed
@adrianschmidt adrianschmidt deleted the create-helper-text-component branch December 18, 2023 13:55
@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.1.0-next.75 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants