Switch sampler and ycbcr conversion order in state writer #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 357943. |
panos-lunarg
force-pushed
the
switch_sampler_and_ycbcr_conversion_order_in_state_writer
branch
from
6b25f31 to
6c240dd
Compare
|
CI gfxreconstruct build queued with queue ID 357944. |
|
CI gfxreconstruct build # 5950 running. |
|
CI gfxreconstruct build # 5950 passed. |
panos-lunarg
force-pushed
the
switch_sampler_and_ycbcr_conversion_order_in_state_writer
branch
from
6c240dd to
e73987a
Compare
|
CI gfxreconstruct build queued with queue ID 359160. |
|
CI gfxreconstruct build # 5959 running. |
|
CI gfxreconstruct build # 5959 passed. |
bradgrantham-lunarg
approved these changes
Jan 29, 2025
Sampler and image view create infos can reference a VkSamplerYcbcrConversion object. This means that the Vulkan state writer needs to first dump all VkSamplerYcbcrConversion objects before it dumps samplers and image views
panos-lunarg
force-pushed
the
switch_sampler_and_ycbcr_conversion_order_in_state_writer
branch
from
e73987a to
175c8f0
Compare
|
CI gfxreconstruct build queued with queue ID 359661. |
|
CI gfxreconstruct build # 5965 running. |
|
CI gfxreconstruct build # 5965 passed. |
panos-lunarg
deleted the
switch_sampler_and_ycbcr_conversion_order_in_state_writer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.