-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marky update loop event handling #1860
Marky update loop event handling #1860
Conversation
CI gfxreconstruct build queued with queue ID 292992. |
CI gfxreconstruct build # 5266 running. |
CI gfxreconstruct build queued with queue ID 293015. |
b370cc6
to
0e7d890
Compare
CI gfxreconstruct build queued with queue ID 293060. |
Accidentally included a submodule update in last run. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much nicer, a couple nits, a functional question, and a storage question or two.
CI gfxreconstruct build # 5270 running. |
CI gfxreconstruct build # 5270 passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more little nit.
CI gfxreconstruct build queued with queue ID 295086. |
CI gfxreconstruct build # 5284 running. |
CI gfxreconstruct build # 5284 passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update the replay logic to handle waiting for missing events. If the event is a known important event, we will always wait for it. If the event is not important, or unknown, every time we miss receiving the event, we will wait less next time. We will always wait at least once for every event, but if it's an event that we never receive, we will no longer than one xrPollEvent query for it.
ba56c2d
to
5c7979d
Compare
CI gfxreconstruct build queued with queue ID 299897. |
CI gfxreconstruct build # 5331 running. |
CI gfxreconstruct build # 5331 passed. |
No description provided.