Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marky update loop event handling #1860

Conversation

MarkY-LunarG
Copy link
Contributor

No description provided.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 292992.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5266 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 293015.

@MarkY-LunarG MarkY-LunarG added the openxr-experimental Related to OpenXR experimental support label Nov 1, 2024
@MarkY-LunarG MarkY-LunarG force-pushed the marky-update-loop-event-handling branch from b370cc6 to 0e7d890 Compare November 1, 2024 21:12
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 293060.

@MarkY-LunarG
Copy link
Contributor Author

Accidentally included a submodule update in last run. Fixed.

Copy link
Contributor

@jzulauf-lunarg jzulauf-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much nicer, a couple nits, a functional question, and a storage question or two.

external/Vulkan-Headers Outdated Show resolved Hide resolved
framework/decode/openxr_replay_consumer_base.cpp Outdated Show resolved Hide resolved
framework/decode/openxr_replay_consumer_base.cpp Outdated Show resolved Hide resolved
framework/decode/openxr_replay_consumer_base.cpp Outdated Show resolved Hide resolved
framework/decode/openxr_replay_consumer_base.cpp Outdated Show resolved Hide resolved
framework/decode/openxr_replay_consumer_base.cpp Outdated Show resolved Hide resolved
framework/decode/openxr_replay_consumer_base.cpp Outdated Show resolved Hide resolved
framework/decode/openxr_replay_consumer_base.h Outdated Show resolved Hide resolved
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5270 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5270 passed.

Copy link
Contributor

@jzulauf-lunarg jzulauf-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more little nit.

framework/decode/openxr_replay_consumer_base.h Outdated Show resolved Hide resolved
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 295086.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5284 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5284 passed.

Copy link
Contributor

@jzulauf-lunarg jzulauf-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Update the replay logic to handle waiting for missing events.
If the event is a known important event, we will always wait for it.
If the event is not important, or unknown, every time we miss receiving
the event, we will wait less next time.  We will always wait at least
once for every event, but if it's an event that we never receive,
we will no longer than one xrPollEvent query for it.
@MarkY-LunarG MarkY-LunarG force-pushed the marky-update-loop-event-handling branch from ba56c2d to 5c7979d Compare November 11, 2024 14:56
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 299897.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5331 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5331 passed.

@MarkY-LunarG MarkY-LunarG merged commit 42f41fc into LunarG:openxr-experimental Nov 11, 2024
9 checks passed
@MarkY-LunarG MarkY-LunarG deleted the marky-update-loop-event-handling branch November 11, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openxr-experimental Related to OpenXR experimental support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants