Add missing pipeline binaries struct entry #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 278597. |
|
CI gfxreconstruct build # 5065 running. |
ziga-lunarg
force-pushed
the
ziga-fix-pipeline-binaries
branch
from
1db9109
to
44badeb
Compare
|
CI gfxreconstruct build queued with queue ID 278617. |
|
CI gfxreconstruct build # 5066 running. |
|
CI gfxreconstruct build # 5066 passed. |
bradgrantham-lunarg
approved these changes
Oct 15, 2024
|
Hey, @MarkY-LunarG , do you want a chance to review this or can Ziga merge? |
MarkY-LunarG
approved these changes
Oct 21, 2024
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VkPipelineBinaryHandlesInfoKHRcontains a dynamic array and must be handled differently.Currently any attempt to call
vkCreatePipelineBinariesKHRwould assert inAddStructGroupEntry.