Fix tracking queue family properties #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 278563. |
|
CI gfxreconstruct build # 5064 running. |
|
CI gfxreconstruct build # 5064 passed. |
bradgrantham-lunarg
approved these changes
Oct 14, 2024
|
@MarkY-LunarG if I reviewed this and it looks good, are you okay with @ziga-lunarg merging it or do you want a chance to review? |
|
I'm ok with this. This might be something we have to do in other API entrypoints (like EnumPhysDevs). But let's start with this for now. |
MarkY-LunarG
approved these changes
Oct 15, 2024
ziga-lunarg
force-pushed
the
ziga-fix-tracking-queue-family-properties
branch
from
3b94abb
to
a663a1b
Compare
|
CI gfxreconstruct build queued with queue ID 279427. |
|
CI gfxreconstruct build # 5081 running. |
|
CI gfxreconstruct build # 5081 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a case where an app did:
vkGetPhysicalDeviceQueueFamilyProperties()to get the countvkGetPhysicalDeviceQueueFamilyProperties()with the countvkGetPhysicalDeviceQueueFamilyProperties()with 1And we just stored the 1.