Add log message on app gain/loss of focus and when unpausing application #1780
Conversation
|
CI gfxreconstruct build queued with queue ID 269472. |
|
CI gfxreconstruct build # 4940 running. |
|
CI gfxreconstruct build # 4940 passed. |
|
CI gfxreconstruct build queued with queue ID 273399. |
|
CI gfxreconstruct build # 4969 running. |
|
CI gfxreconstruct build # 4969 passed. |
|
This doesn't appear to work like I'd expect. The pause and resume messages are out of order. Here's the result from our job 4940, before my commit to your branch: |
| { | ||
| uint32_t current_frame = file_processor_->GetCurrentFrameNumber(); | ||
| if (current_frame > 0) | ||
| if (paused_) |
There was a problem hiding this comment.
Is it possible this should be paused? paused_ (with underscore) is the previous value of the pause, so this would invert the messages, I think.
There was a problem hiding this comment.
Yes, this is a mistake on my side, I will fix that =)
|
Although I have not paused or resumed replay, I get the messages that playback has been paused and resumed, because the logic no longer checks the frame number. Before this change, there were no extraneous messages about pausing. Can that behavior be restored? |
bradgrantham-lunarg
added
P2
|
The idea of this commit was to explicitly tell the user that the application starts paused and resume only when it gains focus - because in some cases the app doesn't get the focus, then the replay doesn't start and it seems like a bug of GFXReconstruct when it is in fact a bug of the environment. So we would like to keep messages about what happens at frame 0. |
Change-Id: I3fd493a6cb8520a9ec69078b62f8be31287c8355
marius-pelegrin-arm
force-pushed
the
fix-log-messages-android-focus
branch
from
39fee04
to
e8593ef
Compare
|
CI gfxreconstruct build queued with queue ID 273627. |
|
CI gfxreconstruct build # 4974 running. |
|
CI gfxreconstruct build # 4974 passed. |
It makes more sense to have messages for both when the application is paused and unpaused than only when paused.
In addition, in the context of an automated process, it is useful to be able to differentiate, only with the logs, an application that was paused because of a manual input to an application paused because of a lose of focus.
This commit adds these log messages